Add support for higher order components with any arbitrary depth. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielduan
requested changes
Aug 10, 2017
test/fixtures/hoc/actual.js
Outdated
| } | ||
|
|
||
| Component.propTypes = { | ||
| children: React.PropTypes.string.isRequired, |
There was a problem hiding this comment.
can you add some comments in here like /* comment */ like the other files so we can make sure those are extracted properly?
test/fixtures/hoc/actual.js
Outdated
| style: React.PropTypes.object, | ||
| } | ||
|
|
||
| export default withHoc()(deeperHoc(Component)) |
There was a problem hiding this comment.
would you mind adding another test with just 1 hoc? it's a slightly different test case and I don't want this to regress in case someone refactors this.
|
Thanks for your quick response! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have the need to support higher-order-components in our docs.
So I added the possibility for the plugin to also provide information about these.
For example this needs to be supported:
export default connect()(withRouter(MyComponent))It's supported by
react-docgenbut not by this plugin. With this PR it should also work here :)