From 1e43b973423a7c7dc72f6fa46a3e34e5a756b3d8 Mon Sep 17 00:00:00 2001 From: Norbert de Langen Date: Fri, 14 Feb 2020 22:27:53 +0100 Subject: [PATCH] REMOVE prop-types where no longer needed --- lib/api/package.json | 1 - lib/components/package.json | 1 - lib/components/src/tabs/tabs.tsx | 5 +---- lib/source-loader/package.json | 1 - lib/theming/package.json | 1 - lib/ui/package.json | 1 - lib/ui/paths.js | 1 - lib/ui/scripts/createDlls.js | 1 - lib/ui/src/components/sidebar/SidebarStories.tsx | 5 ----- 9 files changed, 1 insertion(+), 16 deletions(-) diff --git a/lib/api/package.json b/lib/api/package.json index 4973b263742..fcc535eede5 100644 --- a/lib/api/package.json +++ b/lib/api/package.json @@ -39,7 +39,6 @@ "global": "^4.3.2", "lodash": "^4.17.15", "memoizerific": "^1.11.3", - "prop-types": "^15.6.2", "react": "^16.8.3", "semver": "^6.0.0", "shallow-equal": "^1.1.0", diff --git a/lib/components/package.json b/lib/components/package.json index 7dffc46c4d1..8ea1820c231 100644 --- a/lib/components/package.json +++ b/lib/components/package.json @@ -37,7 +37,6 @@ "memoizerific": "^1.11.3", "polished": "^3.4.4", "popper.js": "^1.14.7", - "prop-types": "^15.7.2", "react": "^16.8.3", "react-dom": "^16.8.3", "react-focus-lock": "^2.1.0", diff --git a/lib/components/src/tabs/tabs.tsx b/lib/components/src/tabs/tabs.tsx index c4a743ba588..bab176fefe2 100644 --- a/lib/components/src/tabs/tabs.tsx +++ b/lib/components/src/tabs/tabs.tsx @@ -7,7 +7,6 @@ import React, { MouseEvent, ReactNode, } from 'react'; -import PropTypes from 'prop-types'; import { styled } from '@storybook/theming'; import { Placeholder } from '../placeholder/placeholder'; @@ -108,9 +107,7 @@ export const TabWrapper: FunctionComponent = ({ active, render, {render ? render() : children} ); -export const panelProps = { - active: PropTypes.bool, -}; +export const panelProps = {}; const childrenToList = (children: any, selected: string) => Children.toArray(children).map( diff --git a/lib/source-loader/package.json b/lib/source-loader/package.json index 97a7ed45839..d25616e93f4 100644 --- a/lib/source-loader/package.json +++ b/lib/source-loader/package.json @@ -36,7 +36,6 @@ "global": "^4.3.2", "loader-utils": "^1.2.3", "prettier": "^1.16.4", - "prop-types": "^15.7.2", "regenerator-runtime": "^0.13.3" }, "peerDependencies": { diff --git a/lib/theming/package.json b/lib/theming/package.json index 7afdf558e8b..6107fd7104f 100644 --- a/lib/theming/package.json +++ b/lib/theming/package.json @@ -37,7 +37,6 @@ "global": "^4.3.2", "memoizerific": "^1.11.3", "polished": "^3.4.4", - "prop-types": "^15.7.2", "resolve-from": "^5.0.0", "ts-dedent": "^1.1.1" }, diff --git a/lib/ui/package.json b/lib/ui/package.json index a5caf455412..9bf07277117 100644 --- a/lib/ui/package.json +++ b/lib/ui/package.json @@ -48,7 +48,6 @@ "markdown-to-jsx": "^6.9.3", "memoizerific": "^1.11.3", "polished": "^3.4.4", - "prop-types": "^15.7.2", "qs": "^6.6.0", "react": "^16.8.3", "react-dom": "^16.8.3", diff --git a/lib/ui/paths.js b/lib/ui/paths.js index e14bef875a3..935886acba6 100644 --- a/lib/ui/paths.js +++ b/lib/ui/paths.js @@ -14,7 +14,6 @@ module.exports = { '@storybook/router': dirname(resolve('@storybook/router/package.json')), '@storybook/theming': dirname(resolve('@storybook/theming/package.json')), '@storybook/ui': dirname(resolve('@storybook/ui/package.json')), - 'prop-types': dirname(resolve('prop-types/package.json')), react: dirname(resolve('react/package.json')), 'react-dom': dirname(resolve('react-dom/package.json')), }; diff --git a/lib/ui/scripts/createDlls.js b/lib/ui/scripts/createDlls.js index 10453bf2927..60735f1e1dd 100644 --- a/lib/ui/scripts/createDlls.js +++ b/lib/ui/scripts/createDlls.js @@ -29,7 +29,6 @@ const run = () => '@storybook/theming', 'airbnb-js-shims', 'emotion-theming', - 'prop-types', 'react', 'react-dom', 'regenerator-runtime/runtime', diff --git a/lib/ui/src/components/sidebar/SidebarStories.tsx b/lib/ui/src/components/sidebar/SidebarStories.tsx index f98111dc22b..b16afec2099 100644 --- a/lib/ui/src/components/sidebar/SidebarStories.tsx +++ b/lib/ui/src/components/sidebar/SidebarStories.tsx @@ -1,5 +1,4 @@ import React, { Fragment, FunctionComponent, memo } from 'react'; -import PropTypes from 'prop-types'; import { styled } from '@storybook/theming'; import { Placeholder, Link as StyledLink } from '@storybook/components'; @@ -19,10 +18,6 @@ const Subheading = styled(SidebarSubheading)({ margin: '0 20px', }); -Subheading.propTypes = { - className: PropTypes.string, -}; - Subheading.defaultProps = { className: 'sidebar-subheading', };