Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-a11y: Add preset #9697

Merged
merged 6 commits into from
Feb 4, 2020
Merged

Addon-a11y: Add preset #9697

merged 6 commits into from
Feb 4, 2020

Conversation

dave-cross
Copy link
Contributor

Issue: #9471

What I did

Add preset files based on addon-knobs. Also updated the readme, but it seems to have auto-formatted in interesting ways.

How to test

  • yarn test --core
  • Test in examples/official-storybook by removing parameters from a11y stories.

@dave-cross dave-cross changed the title 9471 a11y preset Add preset to addon-a11y Jan 31, 2020
@CodeByAlex
Copy link
Member

Thanks for the quick turnaround! Could you try adding it to a demo app to ensure it works properly? It might be worth converting all of the demos to use the new format so that we are encouraging others to do so. @shilman any thoughts?

@dave-cross
Copy link
Contributor Author

@CodeByAlex

A pre-existing one like examples/official-storybook? Something else? I can definitely do that (already made changes to official-storybook, but didn't want to commit that in case it's bad practice).

@shilman
Copy link
Member

shilman commented Jan 31, 2020

Thanks @cloudsociety, this is awesome!!!

Like @CodeByAlex said, please add it to all the examples (like official-storybook) as needed. I think what this means is just removing the manual decorator adding and confirm that it can also be disabled easily for some examples.

Also, please add it to MIGRATION.md because it’s actually a breaking change (which is fine—we’re in 6.0 now!!)

@dave-cross
Copy link
Contributor Author

Hopefully got them all. Everything seems to be working. Not sure where to add it in MIGRATION.md. Not really a breaking change. Just added functionality.

But more than happy to update that file with a little guidance.

@shilman shilman added this to the 6.0.0 milestone Feb 4, 2020
@shilman shilman changed the title Add preset to addon-a11y Addon-a11y: Add preset Feb 4, 2020
shilman
shilman approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the migration info. Thanks @cloudsociety !!!

@shilman shilman merged commit 5ae4dae into storybookjs:next Feb 4, 2020
@shilman shilman mentioned this pull request Feb 4, 2020
Closed
@ndelangen
Copy link
Member

Thank you @cloudsociety!

This was referenced Feb 24, 2020
Closed
Closed
This was referenced Feb 24, 2020
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@shilman shilman shilman approved these changes

@CodeByAlex CodeByAlex Awaiting requested review from CodeByAlex

@jbovenschen jbovenschen Awaiting requested review from jbovenschen

@alexandrebodin alexandrebodin Awaiting requested review from alexandrebodin

@alterx alterx Awaiting requested review from alterx

@igor-dv igor-dv Awaiting requested review from igor-dv

@usulpro usulpro Awaiting requested review from usulpro

Assignees
No one assigned
Labels
addon: a11y feature request
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dave-cross @CodeByAlex @shilman @ndelangen