From 2dd074fd137f506d7cc77bbc5b46ee751ff27853 Mon Sep 17 00:00:00 2001 From: Norbert de Langen Date: Fri, 18 Oct 2019 16:24:24 +0200 Subject: [PATCH 1/2] ADD a step in circleci to upload storybook for angular --- .circleci/config.yml | 8 ++++++-- package.json | 1 - 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 389a649622dc..ed8d38cfe754 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -47,8 +47,12 @@ jobs: - attach_workspace: at: . - run: - name: Run chromatic on the pre-built storybook - command: yarn chromatic + name: Run chromatic on the pre-built official example + command: yarn chromatic --storybook-build-dir="built-storybooks/official-storybook" --exit-zero-on-changes --app-code="ab7m45tp9p" + - run: + name: Run chromatic on the pre-built angular example + command: yarn chromatic --storybook-build-dir="built-storybooks/angular-cli" --exit-zero-on-changes --app-code="tl92yzsj6w" + packtracker: <<: *defaults steps: diff --git a/package.json b/package.json index d152cbcbdad7..349ceba1be59 100644 --- a/package.json +++ b/package.json @@ -47,7 +47,6 @@ "build-storybooks": "cross-env STORYBOOK_DISPLAY_WARNING=true DISPLAY_WARNING=true ./scripts/build-storybooks.js", "changelog": "pr-log --sloppy --cherry-pick", "changelog:next": "pr-log --sloppy --since-prerelease", - "chromatic": "chromatic --storybook-build-dir=\"built-storybooks/official-storybook\" --exit-zero-on-changes --app-code=\"ab7m45tp9p\"", "coverage": "codecov", "danger": "danger", "dev": "concurrently --kill-others \"yarn dev:tsc\" \"yarn dev:babel\"", From d2ac2ec7488a09c2239c56dca7da911c5fb34522 Mon Sep 17 00:00:00 2001 From: Norbert de Langen Date: Fri, 18 Oct 2019 16:48:59 +0200 Subject: [PATCH 2/2] remove unnecessary node-sass install --- examples/angular-cli/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/angular-cli/package.json b/examples/angular-cli/package.json index bb6ba73995e0..ac0aa9493b48 100644 --- a/examples/angular-cli/package.json +++ b/examples/angular-cli/package.json @@ -5,7 +5,7 @@ "license": "MIT", "scripts": { "build": "ng build", - "prebuild-storybook": "npm run storybook:prebuild && cd ../.. && yarn add node-sass -W -s && cd examples/angular-cli", + "prebuild-storybook": "npm run storybook:prebuild", "build-storybook": "build-storybook -s src/assets", "e2e": "ng e2e", "ng": "ng",