From 4ed1783586ac09a75e4b76978491f83ad995fc2a Mon Sep 17 00:00:00 2001 From: lonyele Date: Thu, 1 Aug 2019 12:13:23 +0900 Subject: [PATCH 1/2] chore: remove temporarily added --no-dll on examples --- examples/html-kitchen-sink/package.json | 2 +- examples/official-storybook/package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/html-kitchen-sink/package.json b/examples/html-kitchen-sink/package.json index 39d7554cd773..c18050d5b872 100644 --- a/examples/html-kitchen-sink/package.json +++ b/examples/html-kitchen-sink/package.json @@ -11,7 +11,7 @@ "build-storybook": "build-storybook", "generate-addon-jest-testresults": "jest --config=tests/addon-jest.config.json --json --outputFile=stories/addon-jest.testresults.json", "now-build": "node ../../scripts/bootstrap --core && yarn run build-storybook --quiet", - "storybook": "start-storybook -p 9006 --no-dll" + "storybook": "start-storybook -p 9006" }, "devDependencies": { "@storybook/addon-a11y": "5.2.0-beta.19", diff --git a/examples/official-storybook/package.json b/examples/official-storybook/package.json index 0b70034e554b..7b58959a3898 100644 --- a/examples/official-storybook/package.json +++ b/examples/official-storybook/package.json @@ -10,7 +10,7 @@ "graphql": "node ./graphql-server/index.js", "image-snapshots": "yarn run build-storybook && yarn run do-image-snapshots", "now-build": "node ../../scripts/bootstrap --core && yarn run build-storybook --quiet", - "storybook": "cross-env STORYBOOK_DISPLAY_WARNING=true DISPLAY_WARNING=true start-storybook -p 9011 -c ./ -s built-storybooks --no-dll", + "storybook": "cross-env STORYBOOK_DISPLAY_WARNING=true DISPLAY_WARNING=true start-storybook -p 9011 -c ./ -s built-storybooks", "packtracker": "yarn storybook --smoke-test --quiet && cross-env PT_PROJECT_TOKEN=1af1d41b-d737-41d4-ac00-53c8f3913b53 packtracker-upload --stats=./node_modules/.cache/storybook/manager-stats.json" }, "devDependencies": { From c4c40bc133f356323a2d9c0409b5dd85effcdf50 Mon Sep 17 00:00:00 2001 From: lonyele Date: Thu, 1 Aug 2019 14:28:28 +0900 Subject: [PATCH 2/2] chore: apply feedback leaving official example --- examples/official-storybook/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/official-storybook/package.json b/examples/official-storybook/package.json index 7b58959a3898..0b70034e554b 100644 --- a/examples/official-storybook/package.json +++ b/examples/official-storybook/package.json @@ -10,7 +10,7 @@ "graphql": "node ./graphql-server/index.js", "image-snapshots": "yarn run build-storybook && yarn run do-image-snapshots", "now-build": "node ../../scripts/bootstrap --core && yarn run build-storybook --quiet", - "storybook": "cross-env STORYBOOK_DISPLAY_WARNING=true DISPLAY_WARNING=true start-storybook -p 9011 -c ./ -s built-storybooks", + "storybook": "cross-env STORYBOOK_DISPLAY_WARNING=true DISPLAY_WARNING=true start-storybook -p 9011 -c ./ -s built-storybooks --no-dll", "packtracker": "yarn storybook --smoke-test --quiet && cross-env PT_PROJECT_TOKEN=1af1d41b-d737-41d4-ac00-53c8f3913b53 packtracker-upload --stats=./node_modules/.cache/storybook/manager-stats.json" }, "devDependencies": {