Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD warning for decorators added "mid-kind" #5819

Merged
merged 3 commits into from
Mar 3, 2019
Merged

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Mar 2, 2019

Issue: #5781

@vercel
Copy link

vercel bot commented Mar 2, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@ndelangen
Copy link
Member

FAIL  examples/angular-cli/angularshots.test.js
  ● Test suite failed to run

    warn: You have added a decorator to the kind 'Custom|Dependencies' after a story has already been added.
    In Storybook 4 this applied the decorator only to subsequent stories. In Storybook 5+ it applies to all stories.
    This is probably not what you intended. Read more here: https://github.com/storybooks/storybook/blob/master/MIGRATION.md

      45 | global.console.warn = throwWarning;
      46 | 

      at throwMessage (scripts/jest.init.js:47:15)
      at BufferedConsole.throwWarning [as warn] (scripts/jest.init.js:57:10)
      at Object.api.addDecorator (lib/client-api/dist/client_api.js:385:17)
      at Object.<anonymous> (examples/angular-cli/src/stories/component-with-di/di.component.stories.ts:20:4)
      at requireContext (node_modules/babel-plugin-require-context-hook/register.js:34:10)
      at examples/angular-cli/.storybook/config.ts:40:12
          at Array.forEach (<anonymous>)
      at loadStories (examples/angular-cli/.storybook/config.ts:39:14)
      at Object.ConfigApi.configure (lib/client-api/dist/config_api.js:120:9)
      at Object.<anonymous> (examples/angular-cli/.storybook/config.ts:44:11)
      at configure (addons/storyshots/storyshots-core/dist/frameworks/configure.js:42:11)
      at Object.load (addons/storyshots/storyshots-core/dist/frameworks/angular/loader.js:43:26)
      at loadFramework (addons/storyshots/storyshots-core/dist/frameworks/frameworkLoader.js:36:17)
      at testStorySnapshots (addons/storyshots/storyshots-core/dist/api/index.js:76:36)
      at Object.<anonymous> (examples/angular-cli/angularshots.test.js:24:30)

@vercel vercel bot requested a deployment to staging March 3, 2019 00:05 Abandoned
@vercel vercel bot requested a deployment to staging March 3, 2019 04:57 Abandoned
@shilman shilman changed the title ADD a warning for #5781 ADD warning for decorators added "mid-kind" Mar 3, 2019
@shilman shilman merged commit 4c3bdf3 into next Mar 3, 2019
@shilman shilman deleted the 5781-warn-mid-decorators branch March 3, 2019 05:21
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 3, 2019
shilman added a commit that referenced this pull request Mar 3, 2019
ADD warning for decorators added "mid-kind"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants