Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chromatic: Fix flaky chromatic tests caused by the next/image component loading #23433

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Chromatic: Fix flaky chromatic tests caused by the next/image component loading #23433

merged 2 commits into from
Jul 21, 2023

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Jul 13, 2023 •
edited
Loading

Closes N/A

What I did

Fixed flaky chromatic tests caused by the next/image component loading

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@valentinpalkovic valentinpalkovic requested a review from yannbf July 13, 2023 08:27
@valentinpalkovic valentinpalkovic added the build Internal-facing build tooling & test updates label Jul 13, 2023
@valentinpalkovic valentinpalkovic self-assigned this Jul 13, 2023
@valentinpalkovic valentinpalkovic changed the title Fix flaky e2e tests caused by the next/image component loading E2E: Fix flaky chromatic tests caused by the next/image component loading Jul 13, 2023
@valentinpalkovic valentinpalkovic changed the title E2E: Fix flaky chromatic tests caused by the next/image component loading Chromatic: Fix flaky chromatic tests caused by the next/image component loading Jul 13, 2023
@valentinpalkovic valentinpalkovic added ci:normal patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jul 13, 2023
@valentinpalkovic valentinpalkovic merged commit 4d2f321 into next Jul 21, 2023
@valentinpalkovic valentinpalkovic deleted the valentin/fix-flaky-e2e-tests branch July 21, 2023 10:18
@github-actions github-actions bot mentioned this pull request Jul 21, 2023
Merged
11 tasks
storybook-bot pushed a commit that referenced this pull request Jul 21, 2023
@valentinpalkovic @storybook-bot
Merge pull request #23433 from storybookjs/valentin/fix-flaky-e2e-tests
d663b39 
Chromatic: Fix flaky chromatic tests caused by the next/image component loading
(cherry picked from commit 4d2f321)
@github-actions github-actions bot mentioned this pull request Jul 21, 2023
Merged
14 tasks
storybook-bot pushed a commit that referenced this pull request Jul 21, 2023
@valentinpalkovic @storybook-bot
Merge pull request #23433 from storybookjs/valentin/fix-flaky-e2e-tests
a2b1b39 
Chromatic: Fix flaky chromatic tests caused by the next/image component loading
(cherry picked from commit 4d2f321)
storybook-bot pushed a commit that referenced this pull request Jul 21, 2023
@valentinpalkovic @storybook-bot
Merge pull request #23433 from storybookjs/valentin/fix-flaky-e2e-tests
5bac490 
Chromatic: Fix flaky chromatic tests caused by the next/image component loading
(cherry picked from commit 4d2f321)
storybook-bot pushed a commit that referenced this pull request Jul 21, 2023
@valentinpalkovic @storybook-bot
Merge pull request #23433 from storybookjs/valentin/fix-flaky-e2e-tests
3a05872 
Chromatic: Fix flaky chromatic tests caused by the next/image component loading
(cherry picked from commit 4d2f321)
storybook-bot pushed a commit that referenced this pull request Jul 21, 2023
@valentinpalkovic @storybook-bot
Merge pull request #23433 from storybookjs/valentin/fix-flaky-e2e-tests
ed00ad2 
Chromatic: Fix flaky chromatic tests caused by the next/image component loading
(cherry picked from commit 4d2f321)
storybook-bot pushed a commit that referenced this pull request Jul 21, 2023
@valentinpalkovic @storybook-bot
Merge pull request #23433 from storybookjs/valentin/fix-flaky-e2e-tests
1082b1d 
Chromatic: Fix flaky chromatic tests caused by the next/image component loading
(cherry picked from commit 4d2f321)
storybook-bot pushed a commit that referenced this pull request Jul 24, 2023
@valentinpalkovic @storybook-bot
Merge pull request #23433 from storybookjs/valentin/fix-flaky-e2e-tests
562ecbd 
Chromatic: Fix flaky chromatic tests caused by the next/image component loading
(cherry picked from commit 4d2f321)
storybook-bot pushed a commit that referenced this pull request Jul 24, 2023
@valentinpalkovic @storybook-bot
Merge pull request #23433 from storybookjs/valentin/fix-flaky-e2e-tests
cff5adc 
Chromatic: Fix flaky chromatic tests caused by the next/image component loading
(cherry picked from commit 4d2f321)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 24, 2023
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

Assignees

@valentinpalkovic valentinpalkovic

Labels
build Internal-facing build tooling & test updates ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valentinpalkovic @yannbf