From 889c3f1d7f780b112c5f96ea5b8da3d034d1820e Mon Sep 17 00:00:00 2001 From: Tom Coleman Date: Mon, 6 Mar 2023 22:31:01 +1100 Subject: [PATCH] Remove pointless `module.hot.decline()` --- code/addons/a11y/src/a11yRunner.ts | 6 ------ code/addons/a11y/src/index.ts | 6 ------ code/addons/actions/src/index.ts | 6 ------ code/addons/backgrounds/src/index.ts | 6 ------ code/addons/highlight/src/index.ts | 4 ---- code/addons/highlight/src/preview.ts | 4 ---- code/addons/jest/src/index.ts | 6 ------ code/addons/links/src/index.ts | 6 ------ code/addons/measure/src/index.ts | 6 ------ code/addons/outline/src/index.ts | 6 ------ code/addons/storysource/src/index.ts | 6 ------ 11 files changed, 62 deletions(-) diff --git a/code/addons/a11y/src/a11yRunner.ts b/code/addons/a11y/src/a11yRunner.ts index bdae3ed91f11..4163017fd7f9 100644 --- a/code/addons/a11y/src/a11yRunner.ts +++ b/code/addons/a11y/src/a11yRunner.ts @@ -1,5 +1,3 @@ -/// - import { global } from '@storybook/global'; import { addons } from '@storybook/preview-api'; import { EVENTS } from './constants'; @@ -7,10 +5,6 @@ import type { A11yParameters } from './params'; const { document, window: globalWindow } = global; -if (module && module.hot && module.hot.decline) { - module.hot.decline(); -} - const channel = addons.getChannel(); // Holds axe core running state let active = false; diff --git a/code/addons/a11y/src/index.ts b/code/addons/a11y/src/index.ts index 2e1faac38ebb..ce28f952df01 100644 --- a/code/addons/a11y/src/index.ts +++ b/code/addons/a11y/src/index.ts @@ -1,8 +1,2 @@ -/// - export { PARAM_KEY } from './constants'; export * from './params'; - -if (module && module.hot && module.hot.decline) { - module.hot.decline(); -} diff --git a/code/addons/actions/src/index.ts b/code/addons/actions/src/index.ts index af315cb75436..d2d3261dc960 100644 --- a/code/addons/actions/src/index.ts +++ b/code/addons/actions/src/index.ts @@ -1,9 +1,3 @@ -/// - export * from './constants'; export * from './models'; export * from './runtime'; - -if (module && module.hot && module.hot.decline) { - module.hot.decline(); -} diff --git a/code/addons/backgrounds/src/index.ts b/code/addons/backgrounds/src/index.ts index d6968d6ab3e3..dafa948eda6c 100644 --- a/code/addons/backgrounds/src/index.ts +++ b/code/addons/backgrounds/src/index.ts @@ -1,8 +1,2 @@ -/// - -if (module && module.hot && module.hot.decline) { - module.hot.decline(); -} - // make it work with --isolatedModules export default {}; diff --git a/code/addons/highlight/src/index.ts b/code/addons/highlight/src/index.ts index 0dba067511ec..6849e07e6184 100644 --- a/code/addons/highlight/src/index.ts +++ b/code/addons/highlight/src/index.ts @@ -1,8 +1,4 @@ export { HIGHLIGHT, RESET_HIGHLIGHT } from './constants'; -if (module && module.hot && module.hot.decline) { - module.hot.decline(); -} - // make it work with --isolatedModules export default {}; diff --git a/code/addons/highlight/src/preview.ts b/code/addons/highlight/src/preview.ts index 9b90e6224122..926e6dad440d 100644 --- a/code/addons/highlight/src/preview.ts +++ b/code/addons/highlight/src/preview.ts @@ -20,10 +20,6 @@ export const highlightObject = (color: string) => ({ boxShadow: '0 0 0 6px rgba(255,255,255,0.6)', }); -if (module && module.hot && module.hot.decline) { - module.hot.decline(); -} - interface HighlightInfo { /** html selector of the element */ elements: string[]; diff --git a/code/addons/jest/src/index.ts b/code/addons/jest/src/index.ts index 5b68c9d9a9a2..bfa9b2efa5e8 100644 --- a/code/addons/jest/src/index.ts +++ b/code/addons/jest/src/index.ts @@ -1,5 +1,3 @@ -/// - import { addons } from '@storybook/preview-api'; import { normalize, sep } from 'upath'; import { ADD_TESTS, defineJestParameter } from './shared'; @@ -62,7 +60,3 @@ export const withTests = (userOptions: { results: any; filesExt?: string }) => { return storyFn(); }; }; - -if (module && module.hot && module.hot.decline) { - module.hot.decline(); -} diff --git a/code/addons/links/src/index.ts b/code/addons/links/src/index.ts index f39228817d21..47751e599680 100644 --- a/code/addons/links/src/index.ts +++ b/code/addons/links/src/index.ts @@ -1,5 +1,3 @@ -/// - import { dedent } from 'ts-dedent'; let hasWarned = false; @@ -20,7 +18,3 @@ export function LinkTo(): null { } export { linkTo, hrefTo, withLinks, navigate } from './utils'; - -if (module && module.hot && module.hot.decline) { - module.hot.decline(); -} diff --git a/code/addons/measure/src/index.ts b/code/addons/measure/src/index.ts index d6968d6ab3e3..dafa948eda6c 100644 --- a/code/addons/measure/src/index.ts +++ b/code/addons/measure/src/index.ts @@ -1,8 +1,2 @@ -/// - -if (module && module.hot && module.hot.decline) { - module.hot.decline(); -} - // make it work with --isolatedModules export default {}; diff --git a/code/addons/outline/src/index.ts b/code/addons/outline/src/index.ts index d6968d6ab3e3..dafa948eda6c 100644 --- a/code/addons/outline/src/index.ts +++ b/code/addons/outline/src/index.ts @@ -1,8 +1,2 @@ -/// - -if (module && module.hot && module.hot.decline) { - module.hot.decline(); -} - // make it work with --isolatedModules export default {}; diff --git a/code/addons/storysource/src/index.ts b/code/addons/storysource/src/index.ts index 5edaf4114ea1..55221ffd2535 100644 --- a/code/addons/storysource/src/index.ts +++ b/code/addons/storysource/src/index.ts @@ -1,9 +1,3 @@ -/// - import { ADDON_ID, PANEL_ID } from './events'; export { ADDON_ID, PANEL_ID }; - -if (module && module.hot && module.hot.decline) { - module.hot.decline(); -}