-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular: Support storybook configuration for projects with only angular Library #15744
Conversation
Nx Cloud ReportCI ran the following commands for commit 1604b61. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good @ThibaudAV ! Are there any documentation updates needed here?
@shilman I think we need to add some documentation on this. But I think I'll do it in another PR when the feature is more complete. |
Note: thow error if project (lib or not) does not have tsConfig options
should allow project with only lib, without `@angular-devkit/build-angular:browser` to complete the configuration, to work more simply
should allow project with only lib, without `@angular-devkit/build-angular:browser` to complete the configuration, to work more simply
only tsConfig is required and can be directly given to storybook using new Angular builder for SB should allow project with only lib, without `@angular-devkit/build-angular:browser` to complete the configuration, to work more simply
b5c97a3
to
1604b61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ThibaudAV !! Looking great 😍
@ThibaudAV OOPS I missed the comment about being a major change ... Should I revert it in 6.4? Or can we figure out how to make it a non-breaking change? For example, put it behind a feature flag? |
Can't wait to see this release officially! I hope we can use it in 6.4! |
@maxisam you can try it out today using:
|
Issue: 🤷♂️
If the use of the native ng builder for sb is well adopted. It solves several issues.
I think, it should be released officially in storybook 7. because it is a major change 🤔
if you're reading this and you're interested, I'd love some feedback on this :)
What I did
Previous PR : #15061
Allows to use sotrybook without relying on an existing configuration (angular.json artifact).
Can be used for projects with only ng library
Only tsConfig is required
ex :
How to test
If your answer is yes to any of these, please make sure to include it in your PR.