-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular: Add compodoc to ng builder #15165
Conversation
Nx Cloud ReportCI ran the following commands for commit ded597c. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
context: BuilderContext | ||
): Observable<void> => { | ||
return new Observable<void>((observer) => { | ||
const finalCompodocArgs = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as here
"compodoc": { | ||
"type": "boolean", | ||
"description": "Execute compodoc before.", | ||
"default": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because is added by default with sb init 🤷♂️
but if the user does not have compodoc it is necessary to manually change to false
I don't know if this is a good situation 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ThibaudAV#1582 does compodoc get installed by default? if so, then we should enable by default. if not, then we should disable by default. open to your opinions, but maybe we will move away from compodoc in the future as requested by some users. but for now i think we do what's consistent with the CLI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Issue: 👾 next of #15061
Add the same features available natively in the storybook init for angular
What I did
Executer compodoc dans les builders angular avant le démarrage de storybook
It also allows to remove the specific script for compodoc in the package.json
the minimal package.json-> script configuration becomes :
And in angular.json :
✏️ A negative point the compodoc logs are not in color 😞
How to test