Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Add TypeScript plugin for Yarn #14534

Merged
merged 2 commits into from
Apr 10, 2021

Conversation

merceyz
Copy link
Contributor

@merceyz merceyz commented Apr 9, 2021

Issue:

What I did

Added the TypeScript plugin for Yarn to automatically install @types packages when adding dependencies without their own types.
https://github.com/yarnpkg/berry/blob/e81dc0d29bb2f41818d9c5c1c74bab1406fb979b/packages/plugin-typescript/README.md

How to test

Run the following command and observe that lodash and @types/lodash is installed into the workspace

yarn workspace @storybook/preact add lodash@4

@merceyz merceyz force-pushed the merceyz/typescript-plugin branch from 425c159 to 36cf515 Compare April 9, 2021 23:42
@shilman shilman added the maintenance User-facing maintenance tasks label Apr 10, 2021
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman changed the title chore: add TypeScript plugin for Yarn Maintenance: Add TypeScript plugin for Yarn Apr 10, 2021
@shilman shilman merged commit c4942b3 into storybookjs:next Apr 10, 2021
@merceyz merceyz deleted the merceyz/typescript-plugin branch April 10, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants