Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Check webpack version #14256

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Core: Check webpack version #14256

merged 2 commits into from
Mar 17, 2021

Conversation

shilman
Copy link
Member

@shilman shilman commented Mar 17, 2021 •
edited
Loading

Issue: #14252

What I did

Added version checks:

  • builder-webpack4 - ensure webpack4 instance
  • builder-webpack5 - ensure webpack5 instance
  • core-server manager builder - ensure webpack4 instance

How to test

I manually set the wrong version using yarn resolutions in a test project

@shilman shilman added maintenance User-facing maintenance tasks core labels Mar 17, 2021
tmeasday
tmeasday approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I think you could type the object a tiny bit ({version?: string } maybe?) and cast to it

@shilman shilman merged commit a2a9028 into next Mar 17, 2021
@shilman shilman deleted the 14252-check-webpack-version branch March 17, 2021 08:40
This was referenced Mar 17, 2021
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@shilman shilman mentioned this pull request Mar 17, 2021
Closed
3 tasks
This was referenced Mar 17, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees
No one assigned
Labels
core maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @tmeasday