Core: Fix package duplication issues by aliasing all storybook packages #11092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
requested review from
alterx,
igor-dv,
stijnkoopal and
tmeasday
as code owners
tooppaaa
reviewed
Jun 9, 2020
| @@ -21,6 +23,29 @@ import { toRequireContextString } from './to-require-context'; | |||
| import { useBaseTsSupport } from '../config/useBaseTsSupport'; | |||
|
|
|||
| const reactPaths = {}; | |||
| const storybookPaths = { | |||
There was a problem hiding this comment.
const storybookPaths = ['addons', ...other ].reduce((paths,package) => ({
...paths,
[`@storybook/${package}`]: path.dirname(resolveFrom(__dirname, `@storybook/${package}/package.json`))`
}), {});Would reduce boilerplate a bit :)
shilman
changed the title
|
@gaetanmaisse @tooppaaa @shilman @mrmckeb want to review this? 🙇 |
| 'client-api', | ||
| 'client-logger', | ||
| ].reduce( | ||
| (acc, package) => ({ |
There was a problem hiding this comment.
package is not a valid variable name in JS 😉 => sbPackage
| @@ -52,7 +52,9 @@ | |||
| "@babel/register": "^7.8.3", | |||
| "@storybook/addons": "6.0.0-beta.23", | |||
| "@storybook/api": "6.0.0-beta.23", | |||
| "@storybook/channels": "6.0.0-beta.23", | |||
There was a problem hiding this comment.
These are added to be sure to have them and be able to have a working alias?
There was a problem hiding this comment.
Yeah all packages of @storybook/* that are conceivably used are aliased here so that there can only 1 of them in the entire bundle.
# Conflicts: # examples/cra-kitchen-sink/.storybook/main.js
IanVS
pushed a commit
to storybookjs/builder-vite
that referenced
this pull request
Nov 19, 2021
Closes #50 Closes #157 This is the same fix as storybookjs/storybook#11092
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #10887
What I did
I added aliases for all storybook related packages for the preview