-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon-docs - HTML comment in Vue template gives warning #9821
Comments
@pocka is this something you can look at? 🙏 |
The error appears when you put an HTML comment before vue-styleguidist/vue-styleguidist#749 WorkaroundsYou could suppress the error by 1) moving the comment line, or 2) adding <template>
<!-- OK -->
<div>
<!-- ERROR -->
<slot/>
<!-- OK -->
</div>
</template> <template>
<div>
<!-- @slot This would appear as a slot description -->
<slot/>
</div>
</template> |
Thanks so much for the quick turnaround on this @pocka. You're amazing! 💯 |
[email protected], which includes the patch, has been released. I've not tried yet but I think it also solves the multi line comment problem too. |
Describe the bug
I am using addon-docs.
Adding a HTML comment to my Vue component template, gives me the following warning in when running storybook:
To Reproduce
Steps to reproduce the behavior:
npm i && npm run storybook:serve
Expected behavior
No warning. I'm not sure if the HTML comment should appear in storybook but I didn't expect it to.
System:
System:
OS: macOS Mojave 10.14.6
CPU: (4) x64 Intel(R) Core(TM) i5-7600 CPU @ 3.50GHz
Binaries:
Node: 10.15.0 - ~/.nvm/versions/node/v10.15.0/bin/node
npm: 6.13.1 - ~/.nvm/versions/node/v10.15.0/bin/npm
Browsers:
Chrome: 80.0.3987.87
Firefox: 71.0
Safari: 13.0.5
npmPackages:
@storybook/addon-docs: ^5.3.12 => 5.3.12
@storybook/vue: ^5.3.12 => 5.3.12
npmGlobalPackages:
@storybook/cli: 5.3.12
The text was updated successfully, but these errors were encountered: