Typescript compatibility

[shilman]

Issue by mdcorriveau
Friday Mar 31, 2017 at 19:07 GMT
Originally opened as storybook-eol/react-storybook-addon-info#144

---

Hi,

I'm currently converting my react application and storybook to typescript. I currently have a bunch of error with the addWithInfo which return this error :
TS2339:Property 'addWithInfo' does not exist on type 'Story'.

While react-storybook is already providing a storybook.d.ts file in their package, do you think it'll be a great idea to do the same with react-storybook-addon-info ?

Thanks

[shilman]

Comment by ndelangen
Friday Mar 31, 2017 at 19:35 GMT

---

Hey @mdcorriveau, thank you for reporting! Sounds you know a thing or 2 about typescript, would you be able to help us out by creating a PR?

[shilman]

Comment by mnmtanish
Saturday Apr 01, 2017 at 10:45 GMT

---

I've never done this before but perhaps we can add a type definition file to this repo which will add the method to the story type. I found this page in typescript documentation about merging type declarations. I'll check it out and comment here.

[mdcorriveau]

Sorry i've just seen your message, i'll try to give you some info tomorrow !

[ndelangen]

The custom .addBlahBlah() stuff is a bad idea, and we need to provide better ways to add addon-data to stories.

That will make this problem go away too.

Ideas and solution are welcome, but I'm not going to fix this, because long term this is not how we want to do things.

Related #1209

[mucsi96]

I created a PR containing a new example for React + TypeScript #5011