viewMode enhancement

[atanasster]

Adding a new Tab type of storybook addon generates an error:

Warning: Failed prop type: Invalid prop viewModeof valuedepssupplied toPreview, expected one of ["story","info","docs","settings"]

example usage:
https://github.com/atanasster/storybook-addon-deps/blob/master/src/register.tsx

Currently viewMode prop for addons is declared in several places:

1. storybook/lib/ui/src/app.js

   Line 77 in d7c3653

   viewMode: PropTypes.oneOf(['story', 'info', 'docs', 'settings']),

2. storybook/lib/ui/src/components/layout/container.js

   Line 556 in d7c3653

   viewMode: PropTypes.oneOf(['story', 'info', 'docs', 'settings']),

3. storybook/lib/ui/src/components/layout/desktop.js

   Line 74 in d7c3653

   viewMode: PropTypes.oneOf(['story', 'info', 'docs', 'settings']),

4. storybook/lib/ui/src/components/layout/mobile.js

   Line 204 in d7c3653

   viewMode: PropTypes.oneOf(['story', 'info', 'docs', 'settings']),

5. storybook/lib/ui/src/components/preview/preview.js

   Line 316 in d7c3653

   viewMode: PropTypes.oneOf(['story', 'info', 'docs', 'settings']),

This is a proposal to consolidate all those declarations into a single place to remove code duplication and to allow a generic string as a possible viewMode value so an addon can register any type of Tab.

[ndelangen]

The typings say it can also be any string, the propTypes should be changed to allow this.

[shilman]

Gadzooks!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.3.0-beta.12 containing PR #8994 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.