Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addon-docs show code block bleeds CSS classes #8758

Closed
MrHus opened this issue Nov 8, 2019 · 2 comments
Closed

addon-docs show code block bleeds CSS classes #8758

MrHus opened this issue Nov 8, 2019 · 2 comments

Comments

@MrHus
Copy link

MrHus commented Nov 8, 2019

Describe the bug
The addon-docs uses a CSS class called tag which collides with CSS classes used in the
style from the library it is documenting.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://42bv.github.io/ui/storybook/?path=/docs/core-asynccontent--when-loaded
  2. Click on show code
  3. Notice the blue background on tags, and the missing text

Expected behavior
I expect to see a code block which can be read by the user.

Screenshots
Screenshot 2019-11-08 at 09 46 41

System:
Environment Info:

System:
OS: macOS Mojave 10.14.6
CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
Binaries:
Node: 10.16.3 - ~/.nvm/versions/node/v10.16.3/bin/node
Yarn: 1.19.1 - ~/.nvm/versions/node/v10.16.3/bin/yarn
npm: 6.9.0 - ~/.nvm/versions/node/v10.16.3/bin/npm
Browsers:
Chrome: 78.0.3904.97
Firefox: 70.0
Safari: 13.0.3
npmPackages:
@storybook/addon-actions: 5.2.5 => 5.2.5
@storybook/addon-docs: 5.2.5 => 5.2.5
@storybook/preset-scss: 1.0.2 => 1.0.2
@storybook/preset-typescript: 1.1.0 => 1.1.0
@storybook/react: 5.2.5 => 5.2.5

@stale
Copy link

stale bot commented Nov 29, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@shilman
Copy link
Member

shilman commented Feb 11, 2020

Closing this as dupe to #9414 which has more detail

@shilman shilman closed this as completed Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants