Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember panel sizes in local-storage. #869

Closed
shilman opened this issue Apr 15, 2017 · 5 comments
Closed

Remember panel sizes in local-storage. #869

shilman opened this issue Apr 15, 2017 · 5 comments

Comments

@shilman
Copy link
Member

shilman commented Apr 15, 2017

Issue by philcockfield
Thursday Nov 24, 2016 at 19:50 GMT
Originally opened as storybook-eol/storybook-ui#62


Cross referencing this issue over to the actual repo: #466


Would be great if the action-logger panel, and the index panel, didn't not lose their size between page loads.

image

@shilman
Copy link
Member Author

shilman commented Apr 15, 2017

Comment by willowcheng
Tuesday Apr 11, 2017 at 03:47 GMT


Would love to see that width can be remembered if down panel is configured to be displayed on right.

@shilman
Copy link
Member Author

shilman commented Apr 15, 2017

Comment by ndelangen
Tuesday Apr 11, 2017 at 05:04 GMT


PR is very much welcome @willowcheng ❤️

@shilman
Copy link
Member Author

shilman commented Apr 15, 2017

Comment by benediktvaldez
Tuesday Apr 11, 2017 at 20:24 GMT


Does this previous change not solve this issue as well @willowcheng ? Haven't tried it out though, but if not, it could at least be an idea of how to tackle it.

https://github.com/storybooks/storybook-ui/pull/74/files#diff-45accb91d04d726de15be9e2a89530ebR172

@shilman
Copy link
Member Author

shilman commented Apr 15, 2017

Comment by willowcheng
Wednesday Apr 12, 2017 at 03:51 GMT


Hi @benediktvaldez, it actually works and I thought it's already available to newest storybook release.

Created #80 to remember both width and height in case of use cases that need to switch panel position. I found that by dragging splitter and then changing down panel position, the height would be instantly carried to width without applying rendering, no idea how to solve it.

@ndelangen
Copy link
Member

I will close this as a duplicate of #466

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants