Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Docs breaks emotion theming #8601

Closed
shilman opened this issue Oct 29, 2019 · 5 comments
Closed

Addon-docs: Docs breaks emotion theming #8601

shilman opened this issue Oct 29, 2019 · 5 comments

Comments

@shilman
Copy link
Member

shilman commented Oct 29, 2019

Addon-docs is incompatible with component libraries that use emotion theming, since it uses emotion theming itself.

To fix this, we would need to hide Storybook's theme somehow.

As a workaround, you can set your stories to render in iframes in docs. In your .storybook/config.js:

import { addParameters } from '@storybook/react';

addParameters({
  docs: {
    inlineStories: false,
    iframeHeight: '60px', // some default height
  }
});
@stale
Copy link

stale bot commented Nov 19, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added inactive and removed inactive labels Nov 19, 2019
@stale
Copy link

stale bot commented Dec 11, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Dec 11, 2019
@stale
Copy link

stale bot commented Jan 10, 2020

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed Jan 10, 2020
@GitProdEnv
Copy link

Is there another solution to this? I have the same issue, where my component library is built with emotion.

Accessing the theme within the styled components does not work, since the docs addon overwrites the theme.

I do the workaround as mentioned above. Any help appreciated

@shilman
Copy link
Member Author

shilman commented Apr 5, 2021

@GitProdEnv there's an open PR to replace Storybook's theming with a custom context to avoid conflicts. I'm hoping we can get that into 6.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants