Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull request template #740

Closed
shilman opened this issue Apr 2, 2017 · 2 comments
Closed

Pull request template #740

shilman opened this issue Apr 2, 2017 · 2 comments
Assignees
@shilman
Labels
discussion
Milestone
v3.0.0

Comments

@shilman
Copy link
Member

shilman commented Apr 2, 2017 •
edited by ndelangen
Loading

Proposing a pull request template to encourage people to reference the issue they are addressing, provide a short description of their work, and most importantly provide a short summary of how to test the change.

Testing instructions make reviewing the change faster, and also force the submitter to think that through before they issue the PR.
@shilman shilman self-assigned this Apr 2, 2017
@shilman shilman mentioned this issue Apr 2, 2017
Merged
@shilman
Copy link
Member Author

shilman commented Apr 2, 2017 •
edited
Loading

Submitted a template for comments and the PR itself is an example of the template in action: #741

@shilman shilman added the ready label Apr 2, 2017
@ndelangen ndelangen added this to the v3.0.0 milestone Apr 2, 2017
@shilman
Copy link
Member Author

shilman commented Apr 3, 2017

Merged the PR and we can iterate as needed.

@ndelangen ndelangen removed the ready label Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shilman shilman

Labels
discussion
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
2 participants
@shilman @ndelangen