Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error caught when start storybook from angular project without 'architect.build' options #6735

Closed
seokju-na opened this issue May 7, 2019 · 3 comments

Comments

@seokju-na
Copy link
Contributor

seokju-na commented May 7, 2019

Describe the bug

https://github.com/storybooks/storybook/blob/next/app/angular/src/server/angular-cli_config.js#L53

In above code, storybook always require architect.build options. This will work most of angular pojects, but when your making library which build from ng-packagr, these options can be empty.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Code snippets
If applicable, add code samples to help explain your problem.

System:

  • OS: [e.g. iOS, Windows10, MacOS]
  • Device: [e.g. iPhoneX, Macbook Pro 2018]
  • Browser: [e.g. chrome, safari]
  • Framework: [e.g. react, vue, angular]
  • Addons: [if relevant]
  • Version: [e.g. 4.0.0]

Additional context
Add any other context about the problem here.

@seokju-na seokju-na changed the title Error when start storybook from angular project without 'architect.build' options Error caught when start storybook from angular project without 'architect.build' options May 7, 2019
@stale
Copy link

stale bot commented May 29, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label May 29, 2019
@stale
Copy link

stale bot commented Jun 28, 2019

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed Jun 28, 2019
@shilman
Copy link
Member

shilman commented Nov 21, 2019

Yee-haw!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.3.0-beta.3 containing PR #6737 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants