Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base themes broken in v5 #5824

Closed
shilman opened this issue Mar 3, 2019 · 3 comments
Closed

Base themes broken in v5 #5824

shilman opened this issue Mar 3, 2019 · 3 comments
Assignees
Milestone

Comments

@shilman
Copy link
Member

shilman commented Mar 3, 2019

Example 1

addParameters({
  options: {
    theme: create({
      base: 'dark',
	}
  }
});

Results:

  • No dark theme
  • Warnings about missing primary/secondary colors

Example 2

addParameters({
  options: {
    theme: create({
      base: 'dark',
      colorPrimary: 'red',
      colorSecondary: 'green',
	}
  }
});

Results:

  • No dark theme
  • No warnings about missing primary/secondary colors

System:

  • Version: 5.0.0-rc.9
@ndelangen
Copy link
Member

I'll make this work:

create({
  base: 'dark',
  colorPrimary: 'red',
  colorSecondary: 'green',
});

@ndelangen
Copy link
Member

PR is open

@shilman
Copy link
Member Author

shilman commented Mar 5, 2019

Ooh-la-la!! I just released https://github.com/storybooks/storybook/releases/tag/v5.0.0-rc.11 containing PR #5843 that references this issue. Upgrade today to try it out!

Because it's a pre-release you can find it on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants