Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix font-family syntax in Angular welcome #5739

Closed
MattPetitt opened this issue Feb 24, 2019 · 4 comments
Closed

Fix font-family syntax in Angular welcome #5739

MattPetitt opened this issue Feb 24, 2019 · 4 comments

Comments

@MattPetitt
Copy link

There's a typo in the angular welcome page css where fontFamily should be font-family.
https://github.com/storybooks/storybook/blob/e8cdeb6371e69ad8c83c743e9e99cf7ff31951dd/app/angular/src/demo/welcome.component.ts#L42

This causes fonts in the angular welcome page to fallback to the default.

I'm happy to contribute the fix, just wanted to leave this ticket here until I got around to it.

@stale
Copy link

stale bot commented Mar 18, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Mar 18, 2019
@Armanio
Copy link
Member

Armanio commented Mar 18, 2019

Any PR welcome!

@shilman
Copy link
Member

shilman commented Mar 20, 2019

Yay!! I just released https://github.com/storybooks/storybook/releases/tag/v5.1.0-alpha.11 containing PR #6193 that references this issue. Upgrade today to try it out!

Because it's a pre-release you can find it on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Mar 20, 2019
@shilman
Copy link
Member

shilman commented Mar 24, 2019

Gadzooks!! I just released https://github.com/storybooks/storybook/releases/tag/v5.0.4 containing PR #6193 that references this issue. Upgrade today to try it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants