Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addon-a11y detects addon-info violations #5680

Closed
mrsufgi opened this issue Feb 20, 2019 · 3 comments
Closed

addon-a11y detects addon-info violations #5680

mrsufgi opened this issue Feb 20, 2019 · 3 comments

Comments

@mrsufgi
Copy link

mrsufgi commented Feb 20, 2019

Describe the bug

that's pretty funny but when I use both withInfo and withA11Y decorators globally together (in v5-rc.3)
the accessibility addon detects:

Ensures the contrast between foreground and background colors meets WCAG 2 AA contrast ratio thresholds

with the problematic class - .info__show-button which belongs to the info button :D

To Reproduce
add both plugins globally
(order doesn't matter)

addDecorator(withA11Y);
addDecorator(withInfo); 

check a11y panel

Expected behavior
0 issues regarding storybook addons

System:

  • OS: MacOS
  • Device: MBR
  • Browser: Chrome
  • Framework: React
  • Addons: a11y, info
  • Version: 5.0.0-rc.3
@shilman
Copy link
Member

shilman commented Feb 20, 2019

We're going to deprecate addon-info soon and move it into the addons panel, which should address this problem: #1147

@mrsufgi
Copy link
Author

mrsufgi commented Feb 21, 2019

so until then, I'll drop addon-info from my storybook :) (i guess it has issues with storyshots too)

@shilman
Copy link
Member

shilman commented Feb 21, 2019

Sorry for the inconvenience. addon-info has been a thorn in our side for a long time now -- I'm really excited to get something better in place as soon as v5 has been released!

@shilman shilman closed this as completed Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants