Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't need storybook-deployer to gh-pages anymore #386

Closed
ritz078 opened this issue Aug 18, 2016 · 4 comments
Closed

Don't need storybook-deployer to gh-pages anymore #386

ritz078 opened this issue Aug 18, 2016 · 4 comments

Comments

@ritz078
Copy link
Contributor

ritz078 commented Aug 18, 2016

https://github.com/blog/2228-simpler-github-pages-publishing

Simply build them in docs folder and make the appropriate settings for the repository.

@arunoda
Copy link
Member

arunoda commented Aug 18, 2016

Yeah. We can set a prepublish script or something like that to generate the storybook and put it into the docs directory.

@arunoda
Copy link
Member

arunoda commented Aug 18, 2016

I'll put this into the next version of documentation.

@travi
Copy link

travi commented Aug 29, 2016

since this would mean versioning that auto-generated docs/ folder, i personally would not prefer that change. i actually prefer to have a CI job run to do this automatically rather than dealing with the noise of generated files in git.

just throwing this on the table as a reminder that some prefer the current approach in case something is done to change in this direction. please at least keep the current approach as an option

@arunoda
Copy link
Member

arunoda commented Aug 29, 2016

Yep. We are not going to kill this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants