Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 6 readme #3713

Closed
therepo90 opened this issue Jun 5, 2018 · 6 comments
Closed

Angular 6 readme #3713

therepo90 opened this issue Jun 5, 2018 · 6 comments

Comments

@therepo90
Copy link

Bug or support request summary

  1. I can't get my head around adding decorator wrapping my story into a div
  2. I can't make my storybook to serve static assets

Readme could be improved .

@ev45ive
Copy link

ev45ive commented Jun 5, 2018

+1 Same here. Can`t figure a proper way to:

  1. add global styles
  2. serve assets - like fonts or images that I could use from styles or in templates

Would be good to include in angular docs

@wuyuanyi135
Copy link

Isn't Angular 6.0 support still in alpha? I have to get alpha and apply some workarounds #3593 to make it work.

@igor-dv
Copy link
Member

igor-dv commented Jun 14, 2018

@therepo90 , @ev45ive , what version do you use?

Here is a live example of Angular in storybook v4-alpha. You can see the usage of 'moduleMetadata' decorator in it.

You can add global styles for example by importing them in config.js or adding them to angular.json styles field.

Assets could be surved by adding them to angular.json assets field (there was a bug, but it's already fixed and will be released soon) or using this .

And yeah, reamde can be always improved, and we are looking for help =)

@therepo90
Copy link
Author

These usages don't contain wrappingstories around div. Only dependencies etc.
Assets: well Im using angular assets property and im using dynamic sources(that should be handled from /assets) but they are not ;/

@stale
Copy link

stale bot commented Jul 16, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Jul 16, 2018
@stale
Copy link

stale bot commented Aug 15, 2018

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants