Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules and NPM2 #360

Closed
arunoda opened this issue Aug 5, 2016 · 2 comments
Closed

Modules and NPM2 #360

arunoda opened this issue Aug 5, 2016 · 2 comments

Comments

@arunoda
Copy link
Member

arunoda commented Aug 5, 2016

@mnmtanish I just implemented NPM2 support for storybooks.
See: #356

It'll work with current modules.
But I want to know about how it will work with custom modules (user supplied modules.)

Could you possible to do some review on this.

If there's an issue, we could alias core module repos with require.resolve

@thani-sh
Copy link
Contributor

thani-sh commented Aug 6, 2016

We can try a few open source repos with customised storybook and see whether it works with npm2. We can try repos with custom .babelrc files and webpack config files. If you know any, I can check them out.

@arunoda
Copy link
Member Author

arunoda commented Sep 15, 2016

I think this is working pretty greatly.

@arunoda arunoda closed this as completed Sep 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants