Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CLI to use npm and yarn instead of third party packages #3274

Closed
danielduan opened this issue Mar 23, 2018 · 1 comment
Closed

Refactor CLI to use npm and yarn instead of third party packages #3274

danielduan opened this issue Mar 23, 2018 · 1 comment
Labels
bug cli

Comments

@danielduan
Copy link
Member

Work summary

Our CLI relies on libraries like latest-version to check for the latest version of any published package. This creates a problem when the user is behind a corporate firewall and requires a proxy to access the internet.

#3060

Where to start

https://github.com/storybooks/storybook/blob/master/lib/cli/lib/helpers.js#L12

Acceptance criteria

remove dependencies on latest-version and call npm or yarn when checking for latest version and installing

Who to contact

Me
@felipedeboni felipedeboni mentioned this issue Mar 24, 2018
Merged
@issue-sh issue-sh bot removed merged labels Mar 24, 2018
@Hypnosphi
Copy link
Member

Released as 3.4.0-rc.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug cli
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielduan @Hypnosphi