Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending webpack config fails without user-provided module property (storybook/vue) #3215

Closed
hoopyfroody opened this issue Mar 15, 2018 · 8 comments

Comments

@hoopyfroody
Copy link

hoopyfroody commented Mar 15, 2018

Issue details

This issue is exactly as described in #1467, only now with @storybook/vue. I would have tried the fix from that story, but the structure of the part where the webpack config is extended is a little more ancient in storybook-vue it seems and I couldn't quite make it work.

Please specify which version of Storybook and optionally any affected addons that you're running

  • storybook/vue 3.3.15
@igor-dv
Copy link
Member

igor-dv commented Mar 15, 2018

What if you just add empty rules?

{
   module: {
      rules: [],
   },
   plugins: [
     /// ,,,,
   ]
}

@hoopyfroody
Copy link
Author

Yeah, that's the workaround, but that doesn't seem like something you want a user to have to think of.

@Hypnosphi
Copy link
Member

Hypnosphi commented Mar 18, 2018

Looks like we just need to apply #1468 fix to other frameworks. E.g. here's the place to apply it for vue:
https://github.com/storybooks/storybook/blob/master/app/vue/src/server/config.js#L74

Anybody is welcome to open a PR

@Hypnosphi
Copy link
Member

Fix for vue released as 3.4.0-rc.4. Please do the same for angular and polymer

@Hypnosphi Hypnosphi removed the merged label Mar 29, 2018
@stale
Copy link

stale bot commented Apr 19, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Apr 19, 2018
@Hypnosphi Hypnosphi added the todo label Apr 19, 2018
@stale stale bot removed the inactive label Apr 19, 2018
@igor-dv
Copy link
Member

igor-dv commented Apr 19, 2018

It should've been fixed with moving server/config.js to the core

@Hypnosphi
Copy link
Member

Yes, but not for 3.4

@igor-dv
Copy link
Member

igor-dv commented Jun 16, 2018

I think it can be closed already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants