-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enter Full Screen mode without a keyboard #314
Comments
Yeah I know. This is a pain. We will need to implement a mobile UI. |
cc @mnmtanish |
Do you want me to repost in storybook-ui? After some digging, I realize now that is the repo where this change would happen. I don't think the problem is getting into fullscreen (make the icon in the popup a button) but then getting back out |
@aray12 Good question. May be we need to support the shake event or a long press event on the screen. |
After some thought, it might be a good idea to completely rethink the approach for mobile. Responsive development is only becoming more important and in a perfect world I would see my components in both desktop and mobile (using something like browser-sync) simultaneously as I build for the basic visual testing. I noticed in #378 that you use storybook to match design which is exactly how we use it as well. But the mobile experience is lacking in storybook
I love using storybook and it has tremendously improved productivity and transparency, but I have found myself considering building a custom implementation. But that would take a bit of work to be as useful. One idea I had was, what if you guys extracted the logic that pulls together all of the stories into its own package so that people could build their own UI on top of that. Pros
Con
This is obviously not fully thought through. The point is rethinking approach for mobile. Any thoughts? Also how do you guys dev for mobile? |
Iframe certainly is problematic with Storybook. To me it would make more sense to
-> addon related info etc. should be showed on off-screen canvas. |
It could be solved by adding this #867 feature. |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. We do try to do some housekeeping every once in a while so inactive issues will get closed after 90 days. Thanks! |
Hey there, it's me again! I am going to help our maintainers close this issue so they can focus on development efforts instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook! |
I'd love to be able to test certain items on my phone, but I can't enter full screen without the keyboard. I know I can test most items by just resizing the window, but I'd also like to test how certain items look with a keyboard taking up 1/3 of the screen etc.
Thoughts?
The text was updated successfully, but these errors were encountered: