Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular Knobs: URL knob params reset to default on page load #3042

Closed
cwmrowe opened this issue Feb 20, 2018 · 4 comments
Closed

Angular Knobs: URL knob params reset to default on page load #3042

cwmrowe opened this issue Feb 20, 2018 · 4 comments

Comments

@cwmrowe
Copy link

cwmrowe commented Feb 20, 2018

Issue details

When using the knobs addon for Angular. When you change the knob default values, the URL is updated to reflect the changes. However if you reload the page or open the link on another tab, the defaults are restored on the page and in the URL. I would expect that the URL would not change and the knob values from the URL would be reflected in the knobs panel and story.

Please specify which version of Storybook and optionally any affected addons that you're running

  • @storybook/angular 3.4.0-alpha.8
  • @storybook/addon-knobs 3.4.0-alpha.8

Affected platforms

  • Chrome 63, Windows 10
@stale
Copy link

stale bot commented Mar 24, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Mar 24, 2018
@wadackel
Copy link
Contributor

wadackel commented Apr 1, 2018

Hi, I am having similar problems as well.

https://github.com/storybooks/storybook/blob/d0d6e4fa8b1747641050c929449974a38d34008b/addons/knobs/src/angular/helpers.js#L106-L110

I think that the cause is that resetKnobs is called with the above code.

I expect a good solution 😃

@stale stale bot removed the inactive label Apr 1, 2018
@stale
Copy link

stale bot commented Apr 22, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Apr 22, 2018
@stale
Copy link

stale bot commented May 22, 2018

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants