Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Stories without the 'dev' tags (or filtered stories in general) have empty Controls panel #29827

Open
JReinhold opened this issue Dec 5, 2024 · 1 comment · May be fixed by #30038
Open

Comments

@JReinhold
Copy link
Contributor

JReinhold commented Dec 5, 2024

Describe the bug

When opening a story that is hidden from the sidebar with the '!dev' tag, (via a direct URL) the Controls panel is always empty, both in dev and built.

This also happens when you're at a story and you use the tags filter UI to remove that story from the sidebar. See:

Export-1733435290562.mp4

Reproduction link

https://next--635781f3500dd2c49e189caf.chromatic.com/?path=/story/core-tags-remove--no-dev

Reproduction steps

  1. Open the 'No Dev' story in the UI Storybook: https://next--635781f3500dd2c49e189caf.chromatic.com/?path=/story/core-tags-remove--no-dev
  2. See empty Controls panel
  3. Open the sibling story 'No Autodocs', and see correct Controls panel https://next--635781f3500dd2c49e189caf.chromatic.com/?path=/story/core-tags-remove--no-autodocs

System

Additional context

I haven't looked into if this bug affects other addon panels or manager features than the Controls panel.

Originally reported in #9209 (comment)

@JReinhold JReinhold changed the title [Bug]: Stories without the 'dev' tags have empty Controls panel [Bug]: Stories without the 'dev' tags (or filtered stories in general) have empty Controls panel Dec 5, 2024
@JReinhold
Copy link
Contributor Author

JReinhold commented Dec 5, 2024

Probably the mechanism to filter tags shouldn't be to actually modify the index, but instead be a UI only behavior, in the sidebar only.

I can only imagine this breaks in hundreds of other ways right now, generally our code expects a story to be in the index.

https://github.com/storybookjs/storybook/blob/next/code/core/src/manager-api/modules/stories.ts/#L672-L689

@shilman shilman moved this to Empathy Backlog in Core Team Projects Dec 5, 2024
@shilman shilman linked a pull request Dec 12, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Empathy Backlog
Development

Successfully merging a pull request may close this issue.

2 participants