Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] viteDefaultClientConditions should not be applied in Vite 5 projects #29799

Closed
Tracked by #29531
yannbf opened this issue Dec 4, 2024 · 1 comment
Closed
Tracked by #29531
Assignees

Comments

@yannbf
Copy link
Member

yannbf commented Dec 4, 2024

Feedback from EAP:

Hey. What exactly changed in the latest patch version 8.4.6 of the experimental test addon? We are now getting this, while in version 8.4.5 everything works fine. Error: require() of ES Module /path/to/myuser/project/node_modules/@fortawesome/fontawesome-svg-core/index.mjs not supported.

This is related to viteDefaultClientConditions was added in the vitest plugin in 8.4.6, here: https://github.com/storybookjs/storybook/pull/29710/files#diff-604740f662e4e19338c6063aef059bbac9f56dee9c0f378db77d98ae702c2709R111-R122

@JReinhold
Copy link
Contributor

This is related to viteDefaultClientConditions was added in the vitest plugin in 8.4.6

We're not exactly sure of this, at least trying to fix it via #30055 didn't help.

Closing this because it lacks a minimal reproduction, we can open it again it if becomes relevant.

@JReinhold JReinhold closed this as not planned Won't fix, can't repro, duplicate, stale Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants