Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Sidebar context menu behaves incorrectly in reffed entrys #29686

Closed
Tracked by #29531
JReinhold opened this issue Nov 22, 2024 · 0 comments · Fixed by #29803
Closed
Tracked by #29531

[Bug]: Sidebar context menu behaves incorrectly in reffed entrys #29686

JReinhold opened this issue Nov 22, 2024 · 0 comments · Fixed by #29803

Comments

@JReinhold
Copy link
Contributor

JReinhold commented Nov 22, 2024

The new sidebar context menu is shown whenever a test provider addon determines that it should show for a given entry.

Right now that is true for reffed entries as well (stories in composed Storybooks). It shows up, but the invariant fails because the entry couldn't be found in the index:

Export-1732262108608.mp4

There are multiple solutions here:

  1. Never show the sidebar context menu in refs, ever. This assumes that addons can't do any meaningful with them, which I don't know if is true.
  2. In addon-test specifically, disable the menu entry in refs, because addon-test can't do anything meaningful with them. for this to work in general, we should change the logic to find the entry in the ref as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants