Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Investigate global-setup storybook spawn script sometimes not killing Storybook process #28890

Closed
Tracked by #29531 ...
yannbf opened this issue Aug 15, 2024 · 1 comment · Fixed by #30012
Closed
Tracked by #29531 ...
Assignees

Comments

@yannbf
Copy link
Member

yannbf commented Aug 15, 2024

Sometimes when running tests in watch mode, Storybook spawns correctly but doesn't get killed correctly. It's difficult to reproduce it but could be related to the internal mechanism of killing the process in the global-setup file not being robust.

File where the logic is placed at:
https://github.com/storybookjs/storybook/blob/next/code/addons/test/src/vitest-plugin/global-setup.ts

How to reproduce:

  1. Configure the plugin to use the script:
  plugins: [
    storybookTest({
      storybookScript: 'yarn storybook --no-open'
    })
  ],
  1. Run the tests in watch mode
  2. Kill the process, check if Storybook is also killed
@vanessayuenn
Copy link
Contributor

@yannbf how often is this occurring, based on your experience?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants