Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: mobile view should not hint at keyboard shortcut #25816

Closed
vanessayuenn opened this issue Jan 30, 2024 · 3 comments · Fixed by #25866
Closed

[Bug]: mobile view should not hint at keyboard shortcut #25816

vanessayuenn opened this issue Jan 30, 2024 · 3 comments · Fixed by #25866
Labels
bug good first issue help wanted sev:S4 ui
Milestone
8.0-Stable

Comments

@vanessayuenn
Copy link
Contributor

vanessayuenn commented Jan 30, 2024 •
edited
Loading

Describe the bug

The search bar in mobile view has the keyboard shortcut indicator ⌘ K:
Screenshot 2024-01-25 at 14 38 03

To Reproduce

  1. Open any storybook build
  2. Resize to trigger mobile view
  3. Open menu from bottom left button

System

No response

Additional context

No response
@vanessayuenn vanessayuenn added this to the 8.0-Stable milestone Jan 30, 2024
@KarthiDevelope
Copy link

Still This issue Open , Can i Fix this issue ?

@vanessayuenn
Copy link
Contributor Author

@KarthiDevelope yes! PR welcome! Be sure to check the contribution guide and hop onto the Storybook Discord if you need any help getting started. Looking forward to your contribution! ✨

@tusharwebd tusharwebd mentioned this issue Feb 1, 2024
Merged
8 tasks
@tusharwebd
Copy link
Contributor

Created pull request for issue: #25866. Please review. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue help wanted sev:S4 ui
Projects
No open projects
Storybook 8.0 Roadmap
Status: Done
Milestone
8.0-Stable
Development

Successfully merging a pull request may close this issue.

UI: Remove keyboard shortcut hint in search bar on mobile viewports tusharwebd/storybook
3 participants
@vanessayuenn @tusharwebd @KarthiDevelope