Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hideNoControlsWarning in ControlsPanel #25344

Closed
Tracked by #25331
yannbf opened this issue Dec 27, 2023 · 2 comments · Fixed by #25417
Closed
Tracked by #25331

Remove hideNoControlsWarning in ControlsPanel #25344

yannbf opened this issue Dec 27, 2023 · 2 comments · Fixed by #25417
Assignees
@valentinpalkovic

Comments

@yannbf
Copy link
Member

yannbf commented Dec 27, 2023 •
edited
Loading

Location:

storybook/code/addons/controls/src/ControlsPanel.tsx

Line 20 in b22fd14

/** @deprecated No longer used, will be removed in Storybook 8.0 */

This was referenced Dec 27, 2023
Closed
Merged
@yannbf yannbf self-assigned this Jan 3, 2024
@yannbf
Copy link
Member Author

yannbf commented Jan 4, 2024

This task is currently blocked because of #25417 (comment)

@valentinpalkovic
Copy link
Contributor

This is not blocked anymore. We will continue with the removal. I discussed with @cdedreuille that the flag was controlling another component and it is not meant to hide controls on the docs page.

@jonniebigodes jonniebigodes mentioned this issue Jan 27, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinpalkovic valentinpalkovic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Addon Controls: Remove unused hideNoControlsWarning type storybookjs/storybook
3 participants
@cdedreuille @yannbf @valentinpalkovic