Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Onboarding broken in SB8 #25288

Closed
shilman opened this issue Dec 20, 2023 · 3 comments · Fixed by storybookjs/addon-onboarding#81 or storybookjs/addon-onboarding#82
Closed

[Bug]: Onboarding broken in SB8 #25288

shilman opened this issue Dec 20, 2023 · 3 comments · Fixed by storybookjs/addon-onboarding#81 or storybookjs/addon-onboarding#82

Comments

@shilman
Copy link
Member

shilman commented Dec 20, 2023

Describe the bug

The onboarding addon fails to render properly and blocks user interaction. Probably due to some React version mismatch -- 8.0 manager UI is based on React18, 7.x is React16. Probably just need to create a next branch of the addon & externalize React on it? Or just bump a major?

NOTE: This isn't an issue in 7.x.

image

To Reproduce

In an empty directory:

npx storybook@next init

Then choose react-vite.

System

No response

Additional context

No response

@shilman shilman moved this to Empathy Backlog in Core Team Projects Dec 20, 2023
@vanessayuenn vanessayuenn moved this from Empathy Backlog to Ready for work in Core Team Projects Dec 20, 2023
@yannbf
Copy link
Member

yannbf commented Dec 27, 2023

There are two reasons for this failure, both unrelated to versions of React:

  • The elements are not properly visible (fixed here)
  • One of the steps of the walkthrough will not select the right element, and the users will be stuck. This happens because in Storybook 8 the UI changed, and it's tricky to keep the addon working for both structures of Storybook 7 and 8

@yannbf
Copy link
Member

yannbf commented Dec 27, 2023

There is a fix proposed here:
storybookjs/addon-onboarding#81

@shilman
Copy link
Member Author

shilman commented Jan 23, 2024

Still broken. Reproduction:

mkdir nextjs-empty
cd nextjs-empty
npx storybook@next init

Finally, choose the NextJS option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment