Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @storybook/addon-storyshots #25185

Closed
2 tasks done
Tracked by #25115
valentinpalkovic opened this issue Dec 12, 2023 · 4 comments
Closed
2 tasks done
Tracked by #25115

Remove @storybook/addon-storyshots #25185

valentinpalkovic opened this issue Dec 12, 2023 · 4 comments
Assignees
@yannbf

Comments

@valentinpalkovic
Copy link
Contributor

valentinpalkovic commented Dec 12, 2023 •
edited by yannbf
Loading

Tasks
Preview Give feedback
  2. Auto migration: Detect storyshots addon, remove it and provide link to migration note #25326
    yannbf
@valentinpalkovic valentinpalkovic mentioned this issue Dec 12, 2023
Closed
@valentinpalkovic valentinpalkovic changed the title Remove @storybook/addon-storyshots (https://github.com/storybookjs/storybook/pull/24438) Remove @storybook/addon-storyshots Dec 12, 2023
@illume
Copy link

illume commented Dec 23, 2023

Hello. Is there a discussion somewhere why support for storyshots is being removed?

@valentinpalkovic
Copy link
Contributor Author

The rationale behind this decision can be read here: https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#storyshots-has-been-removed

@illume
Copy link

illume commented Dec 23, 2023

Thanks @valentinpalkovic

I also found this link, https://storybook.js.org/docs/writing-tests/storyshots-migration-guide
Maybe that link would also be a good thing to add to this MIGRATION.md file?

@yannbf
Copy link
Member

yannbf commented Jan 3, 2024

Thanks for the remark @illume! It's been done. :D

@yannbf yannbf closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yannbf yannbf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@illume @yannbf @valentinpalkovic