Error message when removing value from number knob

[binomialstew]

Issue details

There is an error message when removing the value from a "number" knob input:

Warning: `value` prop on `input` should not be null. Consider using an empty string to clear the component or `undefined` for uncontrolled components.

I would expect this to be handled by the knob itself so we can avoid having these error messages in our consoles.

Steps to reproduce

This issue can be seen in the cra-kitchen-sink examples. Run the storybook examples and navigate to a story like 'withKnobs - tweaks static values':

http://localhost:9010/?selectedKind=Addon%20Knobs.withKnobs&selectedStory=tweaks%20static%20values&downPanel=storybooks%2Fstorybook-addon-knobs

Delete the 12.5 from the "Dollars" field. When viewing the console, the error described above will show, along with A component is changing a controlled input of type number to be uncontrolled.

Please specify which version of Storybook and optionally any affected addons that you're running

@storybook/react 3.2.17
@storybook/addon-knobs 3.2.17
react 16.2.0

[Hypnosphi]

Should be quite easy to fix, feel free to send a PR

[M-ZubairAhmed]

hi can I work on this?

[Hypnosphi]

Of course @M-ZubairAhmed
Make sure to refer to CONTRIBUTING.md to get familiar with our dev setup

[ah-adarlow]

A similar issue happens with date knobs as well.

[stale]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!

[kaitmore]

hi @Hypnosphi! I have a PR for this, but I'm getting permission denied when I try to push to origin.

[binomialstew]

@kaitmore, I don't think this is set up to allow direct PRs. You can fork the repo and set the PR to come from your fork, though.

[Hypnosphi]

Released as 4.0.0-alpha.3