Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unclear snippets for Highlight addon docs #24050

Closed
kylegach opened this issue Sep 1, 2023 · 5 comments
Closed

Fix unclear snippets for Highlight addon docs #24050

kylegach opened this issue Sep 1, 2023 · 5 comments

Comments

@kylegach
Copy link
Contributor

kylegach commented Sep 1, 2023

Related discussion: #23951 (comment)

https://storybook.js.org/docs/react/essentials/highlight

Clarify where emit comes from.

@kylegach kylegach converted this from a draft issue Sep 1, 2023
@ATREAY
Copy link
Contributor

ATREAY commented Sep 11, 2023

Hey @kylegach, can I work on this issue?
Also, if you assign me this task, I've got a quick question: where should I put the info about that "emit()" function?

@ATREAY
Copy link
Contributor

ATREAY commented Sep 22, 2023

Hey @kylegach,

I would like to inquire about the status of this issue. Is this issue still open?

@jonniebigodes jonniebigodes moved this from Backlog to Community Effort in Learning Team Sep 24, 2023
@jonniebigodes
Copy link
Contributor

@ATREAY thanks for your interest in helping us improve our documentation. We appreciate it 🙏 ! If you're still interested, please go ahead and submit a contribution.

If you have questions about contributing, check out our documentation or ask us here so that we're able to help you get unblocked.

Looking forward to seeing the pull request up.

Hope you have a fantastic rest of the weekend.

Stay safe

@ATREAY
Copy link
Contributor

ATREAY commented Sep 25, 2023

Hey @jonniebigodes, I've made the necessary changes. Please take a look when you get a chance!

@ATREAY
Copy link
Contributor

ATREAY commented Sep 27, 2023

Hey @jonniebigodes, could you take a look at the changes I've made?
Thanks!

@github-project-automation github-project-automation bot moved this from Community Effort to Done in Learning Team Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants