Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Project - Onboarding]: Adjust created dummy files and Storybook configuration #22784

Closed
1 task done
Tracked by #22558
valentinpalkovic opened this issue May 25, 2023 · 5 comments · Fixed by #23171
Closed
1 task done
Tracked by #22558
Assignees

Comments

@valentinpalkovic
Copy link
Contributor

valentinpalkovic commented May 25, 2023

For the onboarding experience, we have to adjust the created dummy Stories slightly:

  • All the button stories must be displayed in the center of the canvas. Add the appropriate layout setting in the meta section of the button Stories.
  • Remove Introduction.mdx and introduce a new Configure.mdx file. @domyen, @cdedreuille What should the content of the Configure.mdx file be? Could you provide it in this ticket?

Blockers

Preview Give feedback
@valentinpalkovic valentinpalkovic changed the title [Project - Onboarding]: Adjust created dummy files to fit onboarding expectations [Project - Onboarding]: Adjust created dummy files and Storybook configuration Jun 1, 2023
@yannbf
Copy link
Member

yannbf commented Jun 7, 2023

@cdedreuille any news on the design for the mdx file?
@valentinpalkovic should the CLI template stories be changed for all projects or just the ones that will have the onboarding?

@cdedreuille
Copy link
Contributor

I'm still working on the design @yannbf

@valentinpalkovic
Copy link
Contributor Author

@valentinpalkovic should the CLI template stories be changed for all projects or just the ones that will have the onboarding?

Let's change only the ones, which have the onboarding for now.

@yannbf
Copy link
Member

yannbf commented Jun 7, 2023

FYI @valentinpalkovic the code for meta is different in Javascript than it is in Typescript. This goes not only for the generated code from the CLI but also every piece of documentation we have:

Javascript:
image

Typescript:
image

What would you like to do?

  • change every Javascript template + Documentation to use const meta
  • change the Javascript code used in the onboarding to show export default {}

@valentinpalkovic
Copy link
Contributor Author

Second one. We will change the code in the onboarding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants