Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addon-knobs: Failed prop type: Invalid prop knob.value of type array supplied to ObjectType, expected object #2268

Closed
cuzzins opened this issue Nov 8, 2017 · 4 comments

Comments

@cuzzins
Copy link

cuzzins commented Nov 8, 2017

The documentation for the object knob states:
Allows you to get a JSON object or array from the user.

But I get an error in console that it expects only an object:
Failed prop type: Invalid prop knob.value of type array supplied to ObjectType, expected object

The rendering still works correctly, so am assuming something is wrong in the prop type check

This is with the latest version

@danielduan
Copy link
Member

If you'd like to open a PR for this, we'd really appreciate it.

@cuzzins
Copy link
Author

cuzzins commented Nov 8, 2017

Looks like it was fixed a few days ago so should be in the 3.3 release: #2227

Apologies, did do a search but didn't find anything originally, will close.

@cuzzins cuzzins closed this as completed Nov 8, 2017
@Hypnosphi
Copy link
Member

Hypnosphi commented Nov 8, 2017

Yeah, that's actually fixed twice =D #1701 #2227
So the fix is included in 3.3.0-alpha.3 and will be included in the upcoming 3.2.15

@cuzzins
Copy link
Author

cuzzins commented Nov 9, 2017

Glad I didn't fix it a third time! ;-) Thanks folks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants