Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Project - Onboarding]: Implement Tooltip functionality (without styling) #22673

Closed
1 task done
Tracked by #22558
valentinpalkovic opened this issue May 22, 2023 · 0 comments
Closed
1 task done
Tracked by #22558
Assignees

Comments

@valentinpalkovic
Copy link
Contributor

valentinpalkovic commented May 22, 2023

Implement React Component: Tooltip

Objective:

The objective of this issue is to create a new React component named Tooltip. As discussed in storybookjs/addon-onboarding#12, use Floating UI to create the tooltip!

Component Requirements:

1. Properties:

Property Type Description Required
children React.ReactNode Children elements. Yes
anchorElement Element The HTMLElement reference, on which the tooltip should be placed on. Yes
...tooltipProps TooltipProps Tooltip properties for fine-grained control. No

2. Behaviors:

  • The tooltip visibility is controlled outside. The parent component decides whether the tooltip should be displayed or not.
  • Use React.Portal to display the tooltip at document.body to guarantee a proper overlay over the underlying content

3. Design (DRAFT):

image
image

4. Blocked by:

Tasks

Preview Give feedback
  1. valentinpalkovic

Acceptance Criteria:

  • The component is implemented according to the requirements described above, or an existing component is taken that fulfills the requirements.
  • The component passes all defined test cases and has Stories displaying its states
  • The component linked to a figma component in Storybook - speak to designers!
  • You should not implement any complex CSS styles! The design is still a work in progress. The component will be finalized design-wise in a separate ticket. Make sure that the properties and the behaviors are implemented accordingly.
  • Darkening the background or highlighting the reference HTMLElement is not part of this ticket.
@valentinpalkovic valentinpalkovic moved this to Ready for work in Core Team Projects May 23, 2023
@valentinpalkovic valentinpalkovic self-assigned this May 24, 2023
@valentinpalkovic valentinpalkovic moved this from Ready for work to In Progress in Core Team Projects May 24, 2023
@valentinpalkovic valentinpalkovic closed this as not planned Won't fix, can't repro, duplicate, stale May 25, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Core Team Projects May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant