-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: migrate csf-2-to-3 does not work for CSF1 #22408
Comments
Do you a have a reproduction repo you can share? If not, can you create one? Go to https://storybook.new or see repro docs. Thank you! 🙏 |
yes, I write a story for header by csf2. link I'm working on a storybook 6.x to 7.x upgrade these days. I've found that if the property is configured using csf2, the story will automatically upgrade, but just exporting a component won't work. |
The issue here is that the linked example is CSF1 not CSF2. The difference between CSF1 and CSF2 is that the former specifies story functions with no args and the latter accepts args and renders them in your component or in a composition of components. We still support CSF 1, 2, and 3, and I believe that for "no-arg" stories, CSF1 is still the best format. I wonder if this is a documentation issue, or whether the migration should print something out in this case to let the user know that skipping this story is intentional, e.g. |
note to whoever is picking this up: this ☝🏼 should be the task for resolving this issue. |
Describe the bug
After executing the command, the blank line of the file is deleted without any migration modification
pic for result
To Reproduce
No response
System
Additional context
No response
The text was updated successfully, but these errors were encountered: