Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stories glob in mdx codemod and not in mdx automigration #21543

Closed
kasperpeulen opened this issue Mar 10, 2023 · 1 comment · Fixed by #21809
Closed

Update stories glob in mdx codemod and not in mdx automigration #21543

kasperpeulen opened this issue Mar 10, 2023 · 1 comment · Fixed by #21809
Assignees
@kasperpeulen
Labels
bug cli

Comments

@kasperpeulen
Copy link
Contributor

We now update the stories glob in an automigration, but only rename the stories as part of a codemod.

We should change the automigration to only point the user to the codemod, but not do anything.

The codemod should be changed to update the stories glob.
@kasperpeulen kasperpeulen self-assigned this Mar 10, 2023
@kasperpeulen kasperpeulen mentioned this issue Mar 29, 2023
Merged
5 tasks
@shilman
Copy link
Member

shilman commented Mar 31, 2023

Son of a gun!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-rc.11 containing PR #21809 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb@next upgrade --prerelease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kasperpeulen kasperpeulen

Labels
bug cli
Projects
Core Team Projects
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CLI: Update stories glob in mdx codemod and not in mdx automigration storybookjs/storybook
2 participants
@shilman @kasperpeulen