Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Missing react peer dependency on storybook v7 package #20537

Closed
bryanjtc opened this issue Jan 9, 2023 · 2 comments
Closed

[Bug]: Missing react peer dependency on storybook v7 package #20537

bryanjtc opened this issue Jan 9, 2023 · 2 comments
Labels
bug needs triage

Comments

@bryanjtc
Copy link
Member

bryanjtc commented Jan 9, 2023

Describe the bug

The following change: #20459, introduced the warnings below. storybook package depends on @storybook/cli

image
image
image

To Reproduce

https://github.com/bryanjtc/storybook-7-vite-test
Run yarn install

System

System:
    OS: Linux 5.15 Ubuntu 22.04.1 LTS 22.04.1 LTS (Jammy Jellyfish)
    CPU: (12) x64 AMD Ryzen 5 5600X 6-Core Processor
  Binaries:
    Node: 16.17.0 - /tmp/xfs-e389171e/node
    Yarn: 3.2.4 - /tmp/xfs-e389171e/yarn
    npm: 8.15.0 - ~/.nvm/versions/node/v16.17.0/bin/npm

Additional context

No response
@bryanjtc bryanjtc mentioned this issue Jan 9, 2023
Closed
3 tasks
@polRk
Copy link

polRk commented Jan 11, 2023

It's stupid to require react when I use vue...

@bryanjtc
Copy link
Member Author

Solved with #20560

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug needs triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@polRk @bryanjtc