Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: files in the sb-addons/.storybook folder result in 404 on netlify when using Storybook 7 #20513

Closed
Jarvis1010 opened this issue Jan 5, 2023 · 1 comment
Assignees

Comments

@Jarvis1010
Copy link
Contributor

Describe the bug

Files in the sb-addons/.storybook build folder are treated as 404 Not Found when deployed on netlify. It appears to be related to this issue: https://answers.netlify.com/t/hidden-files-removed-in-zip-deploy/8997

My current workaround is to add a step in my build script that will copy all the files into a folder called sb-addons/storybook and add redirects into a netlify.toml config file.

To Reproduce

https://github.com/Bedrock-Layouts/Bedrock

https://63b5b0e9b29f8f0008df08bb--loving-albattani-5b3d39.netlify.app

System

System:
    OS: macOS 13.1
    CPU: (10) arm64 Apple M1 Max
  Binaries:
    Node: 16.14.2 - ~/.nvm/versions/node/v16.14.2/bin/node
    Yarn: 1.22.19 - ~/.yarn/bin/yarn
    npm: 9.2.0 - ~/.nvm/versions/node/v16.14.2/bin/npm
  Browsers:
    Chrome: 108.0.5359.124
    Safari: 16.2
  npmPackages:
    @storybook/addon-actions: ^7.0.0-beta.19 => 7.0.0-beta.19 
    @storybook/addon-essentials: ^7.0.0-beta.19 => 7.0.0-beta.19 
    @storybook/addon-links: ^7.0.0-beta.19 => 7.0.0-beta.19 
    @storybook/react: ^7.0.0-beta.19 => 7.0.0-beta.19 
    @storybook/react-vite: ^7.0.0-beta.19 => 7.0.0-beta.19 
    @storybook/theming: ^7.0.0-beta.19 => 7.0.0-beta.19

Additional context

@ndelangen asked me to tag him in this issue.

@IanVS
Copy link
Member

IanVS commented Jan 5, 2023

@ndelangen

@ndelangen ndelangen self-assigned this Jan 5, 2023
@ndelangen ndelangen moved this to Required for RC in Core Team Projects Jan 5, 2023
@ndelangen ndelangen moved this from Required for RC to In Progress in Core Team Projects Jan 9, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Core Team Projects Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants