Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Support for nrwl/workspace 15.3+ for Angular 15 #20213

Closed
nzacca opened this issue Dec 12, 2022 · 1 comment · Fixed by #20559
Closed

[Bug]: Support for nrwl/workspace 15.3+ for Angular 15 #20213

nzacca opened this issue Dec 12, 2022 · 1 comment · Fixed by #20559
Assignees
Labels
angular bug nx Prioritize Nx compatibility for angular

Comments

@nzacca
Copy link
Contributor

nzacca commented Dec 12, 2022

Describe the bug

When installing Storybook within an Nx 15+ workspace, we receive a peer dependency conflict for the @nrwl/workspace package which requires v14.6.1:

https://github.com/storybookjs/storybook/blob/v7.0.0-beta.3/code/frameworks/angular/package.json#L103

To Reproduce

No response

System

No response

Additional context

Note, here is where the @nrwl/workspace package is referenced within Storybook:

require('@nrwl/workspace').readNxJson();

const nxWorkspace = require('@nrwl/workspace').readWorkspaceConfig({

Also note that readNxJson on line 23 is not exported from @nrwl/workspace so this line will always throw. It is found within @nrwl/devkit:

https://github.com/nrwl/nx/blob/15.3.3/packages/devkit/index.ts#L63

@shilman
Copy link
Member

shilman commented Jan 18, 2023

Ta-da!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-beta.30 containing PR #20559 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb@next upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Jan 18, 2023
@github-project-automation github-project-automation bot moved this from Required for RC to Done in Core Team Projects Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular bug nx Prioritize Nx compatibility for angular
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants