Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: enableShortcuts: false doesn't work with beta.3 #20202

Closed
jpzwarte opened this issue Dec 12, 2022 · 1 comment
Closed

[Bug]: enableShortcuts: false doesn't work with beta.3 #20202

jpzwarte opened this issue Dec 12, 2022 · 1 comment

Comments

@jpzwarte
Copy link
Member

Describe the bug

manager.js:

import { addons } from '@storybook/manager-api';

 addons.setConfig({
   enableShortcuts: false
 });

If you then start storybook, shortcuts are still enabled.

To Reproduce

https://kind-plant-088739303-111.westeurope.1.azurestaticapps.net/?path=/story/editor_editor--api

System

No response

Additional context

No response

@shilman shilman added the ui label Dec 12, 2022
@shilman shilman moved this to Required for RC in Core Team Projects Dec 12, 2022
@ndelangen ndelangen self-assigned this Dec 13, 2022
@ndelangen ndelangen moved this from Required for RC to In Progress in Core Team Projects Dec 14, 2022
@shilman
Copy link
Member

shilman commented Dec 15, 2022

w00t!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-beta.9 containing PR #20264 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Dec 15, 2022
Repository owner moved this from In Progress to Done in Core Team Projects Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants